Removed support for non-per-tensor quantized relu #14788
+32
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14788
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit b59a820 with merge base a39866c ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Oct 3, 2025
Summary: Not supporting quantized relu default, so removing it from ref_implementations Differential Revision: D83874866
This PR needs a
|
added 4 commits
October 6, 2025 13:46
Summary: out shift should be int32 Reviewed By: hsharma35 Differential Revision: D83875670
…ariants Summary: Fix to just call the per tensor variants for quantized conv and quantized relu, since those are the only ones we are supporting. Differential Revision: D83873738
Summary: The original pass didn't fetch the user-provided zero point if it existed, it just assumed a hard-coded zero point. Fixed now. Reviewed By: ethansfng Differential Revision: D83873937
Summary: Not supporting quantized relu default, so removing it from ref_implementations Differential Revision: D83874866
DrJessop
force-pushed
the
export-D83874866
branch
from
4927981 to
b59a820
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Not supporting quantized relu default, so removing it from ref_implementations
Differential Revision: D83874866